Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pagination and search bar to the invoice table #146

Merged
merged 11 commits into from
Sep 7, 2023
Merged

add pagination and search bar to the invoice table #146

merged 11 commits into from
Sep 7, 2023

Conversation

StephDietz
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-learn-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 2:44pm
next-learn-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 2:44pm
next-seo-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 2:44pm

@StephDietz StephDietz marked this pull request as ready for review September 6, 2023 19:05
delbaoliveira
delbaoliveira reviewed Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@delbaoliveira delbaoliveira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a slight layout shift on the table when searching. I think it might be because we're not setting the width for each column, but I'm not sure how we can fix this yet.

CleanShot.2023-09-07.at.11.08.09.mp4

@delbaoliveira delbaoliveira merged commit b8935ab into main Sep 7, 2023
2 checks passed
@delbaoliveira delbaoliveira deleted the add-pagination branch September 7, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delbaoliveira delbaoliveira delbaoliveira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StephDietz @delbaoliveira @manovotny